Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

procs: init at 0.8.5 #61137

Merged
merged 2 commits into from May 8, 2019

Conversation

@dalance
Copy link
Contributor

commented May 8, 2019

Motivation for this change

This PR adds procs, A modern replacement for ps written by Rust.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.


meta = with stdenv.lib; {
description = "A modern replacement for ps written by Rust";
homepage = https://github.com/dalance/procs;

This comment has been minimized.

Copy link
@JohnAZoidberg

JohnAZoidberg May 8, 2019

Contributor

Hint: We're probably going to retire unquoted URL syntax when RFC 45 is accepted.

Suggested change
homepage = https://github.com/dalance/procs;
homepage = "https://github.com/dalance/procs";
buildInputs = stdenv.lib.optional stdenv.isDarwin Security;

meta = with stdenv.lib; {
description = "A modern replacement for ps written by Rust";

This comment has been minimized.

Copy link
@JohnAZoidberg

JohnAZoidberg May 8, 2019

Contributor
Suggested change
description = "A modern replacement for ps written by Rust";
description = "A modern replacement for ps written in Rust";
@JohnAZoidberg

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

Please split it up into two commits and name them as the manual requires:

maintainers: add dalance
procs: init at 0.8.5

@dalance dalance force-pushed the dalance:add_procs branch from 05a4c03 to dd3b53c May 8, 2019

@dalance

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

Thanks. I fixed.

@c0bw3b

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

@GrahamcOfBorg build procs

@c0bw3b

c0bw3b approved these changes May 8, 2019

Copy link
Contributor

left a comment

Tested locally and it works ✔️

@c0bw3b c0bw3b changed the title Add procs procs: init at 0.8.5 May 8, 2019

@c0bw3b

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

Thanks for the contribution to nixpkgs @dalance and great tool :)

@c0bw3b c0bw3b merged commit f300cb1 into NixOS:master May 8, 2019

15 of 16 checks passed

procs on x86_64-darwin Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
procs on aarch64-linux Success
Details
procs on x86_64-linux Success
Details
@dalance

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.