Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid collisions between essential packages #61138

Merged
merged 2 commits into from May 8, 2019

Conversation

@rnhmjoj
Copy link
Contributor

commented May 8, 2019

Motivation for this change

Fix remaining collision between essential packages.
See issue #55886.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rnhmjoj rnhmjoj force-pushed the rnhmjoj:collide branch from c7f0e26 to 87bfe6e May 8, 2019

@JohnAZoidberg

This comment has been minimized.

Copy link
Member

commented May 8, 2019

The priority thing is really not optimal... We should have relative priorities between packages.

@grahamc

This comment has been minimized.

Copy link
Member

commented May 8, 2019

On 19.03, nix-build -E 'with (import <nixpkgs> {}); buildEnv { name = "test"; paths = [coreutils procps]; }' creates a environment where kill and uptime come from coreutils. This feels backwards to me, since procps seems to be the more specific package, but 🤷‍♂ @rnhmjoj I'm assuming this PR retains this behavior?

@rnhmjoj

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

where kill and uptime come from coreutils

Note that on master kill it's actually provided by util-linux.

I'm assuming this PR retains this behavior?

Yes, it does. I opened this PR just to fix those annoying warnings, nothing more.
Anyway, I agree that it would make more sense for procps to override coreutils.

@grahamc grahamc merged commit 52ce589 into NixOS:master May 8, 2019

14 of 16 checks passed

procps, systemd on x86_64-darwin
Details
procps, systemd on x86_64-linux
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
procps, systemd on aarch64-linux Success
Details
@rnhmjoj rnhmjoj referenced this pull request May 9, 2019
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.