Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvidia_x11: 415.27 -> 418.43 - backport from master #61140

Merged
merged 2 commits into from May 11, 2019

Conversation

@yorickvP
Copy link
Contributor

commented May 8, 2019

Motivation for this change

Fixes #57062 on 19.03

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg build linuxPackages_latest.nvidiaPackages.stable linuxPackages_5_0.nvidiaPackages.stable linuxPackages.nvidiaPackages.stable linuxPackages.nvidia_x11
cc @eadwu

eadwu added some commits Feb 22, 2019

nvidia_x11: 415.27 -> 418.43
(cherry picked from commit 48e66e5)
nvidia_x11: 418.43 -> 418.56
(cherry picked from commit 928d51a)
@yorickvP

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

@GrahamcOfBorg build linuxPackages_latest.nvidiaPackages.stable linuxPackages_5_0.nvidiaPackages.stable linuxPackages.nvidiaPackages.stable linuxPackages.nvidia_x11

@yorickvP

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

(cc: @Mic92)

@eadwu

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

Looks fine, though 418.74 was released recently, so it might be better to create a PR for 418.74 before cherry-picking it here to also backport.

See #61164.

@adamtulinius

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

+1, I can confirm the original issue, and have been building 19.03 from my own branch based on 19.03 with these exact two commits cherry-picked on top for quite some time, without issues.

@veprbl

This comment has been minimized.

Copy link
Member

commented May 11, 2019

@veprbl veprbl merged commit c2570ef into NixOS:release-19.03 May 11, 2019

13 of 15 checks passed

linuxPackages.nvidiaPackages.stable, linuxPackages.nvidia_x11, linuxPackages_5_0.nvidiaPackages.stable, linuxPackages_latest.nvidiaPackages.stable on aarch64-linux No attempt
Details
linuxPackages.nvidiaPackages.stable, linuxPackages.nvidia_x11, linuxPackages_5_0.nvidiaPackages.stable, linuxPackages_latest.nvidiaPackages.stable on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.