Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bettercap: 2.11 -> 2.24 #61154

Closed
wants to merge 1 commit into from

Conversation

@fadenb
Copy link
Contributor

commented May 8, 2019

Motivation for this change

New release contains bugfixes and additional functionality.

Have used this updated package for a few days without any issues.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JohnAZoidberg

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

How do you use this package on NixOS?
Just the commandline? Or how do you use the web interface without it trying to install binaries to /usr/...?

@fadenb

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

Just the commandline?

Yes, I only use it on the command line (never tried anything else)

@c0bw3b c0bw3b referenced this pull request May 9, 2019

Merged

bettercap: 2.11 -> 2.24 #61215

2 of 10 tasks complete
@fadenb

This comment has been minimized.

Copy link
Contributor Author

commented May 11, 2019

I am closing this PR in favor of #61215. The other PR by @dtzWill looks more thorough.

@fadenb fadenb closed this May 11, 2019

@c0bw3b

This comment has been minimized.

Copy link
Contributor

commented May 11, 2019

So closing this one in favor of #61215

@fadenb fadenb deleted the fadenb:bettercap_2.24 branch Aug 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.