Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

public-inbox: init at 5a4caaca8f #61158

Closed
wants to merge 5 commits into from
Closed

public-inbox: init at 5a4caaca8f #61158

wants to merge 5 commits into from

Conversation

@catern
Copy link
Contributor

@catern catern commented May 8, 2019

Motivation for this change

Adds the public-inbox application, a suite of tools for managing public archives of mailing lists.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@volth
Copy link
Contributor

@volth volth commented May 8, 2019

I would put the public-inbox application with all its patches to a separate folder.
And to the top-level namespace, just public-inbox not perlPackages.public-inbox.

As examples you can see linode-cli, znapzend, awstats, spamassassin and many other applications written in perl (grep -R perlPackages.buildPerlPackage will help to find others).

CPAN modules are OK to put to perl-packages.nix, they will be tracked and updated by scripts.

@catern catern force-pushed the catern:pubinb branch from fd866b4 to a71b016 Jun 8, 2019
@catern catern changed the title perlPackages.public-inbox: init at 1.1.0-pre1 public-inbox: init at 1.1.0-pre1 Jun 8, 2019
@catern catern force-pushed the catern:pubinb branch from a71b016 to 2a49730 Jun 9, 2019
@catern catern changed the title public-inbox: init at 1.1.0-pre1 public-inbox: init at 5a4caaca8f Jun 11, 2019
@catern
Copy link
Contributor Author

@catern catern commented Jun 11, 2019

There are a number of bugs fixed in master which are not in the "released versions", which are only ad-hoc anyway. I'm not able to use the released version due to the bugs, so I think that will apply to most users. Therefore we can package this snapshot of git, which also obsoletes most of the patches I was carrying. The only patches left are ones for sandbox issues.

@catern
Copy link
Contributor Author

@catern catern commented Jul 2, 2019

@volth ping?

@catern catern force-pushed the catern:pubinb branch from 2a49730 to 6ce9538 Aug 9, 2019
@catern
Copy link
Contributor Author

@catern catern commented Aug 9, 2019

Rebased on master, ready for merge now @volth ? Or should I retarget to staging?

@volth
volth approved these changes Aug 9, 2019
catern added 4 commits May 8, 2019
There are a number of bugs fixed in master which are not in the
"released versions", which are only ad-hoc anyway. I'm not able to use
the released version due to the bugs, so I think that will apply to
most users.
@catern catern force-pushed the catern:pubinb branch from 6ce9538 to fd1c852 Aug 9, 2019
@teto
Copy link
Contributor

@teto teto commented Dec 16, 2019

Was looking into packaging it. Could you rebase please ?

@alyssais
Copy link
Member

@alyssais alyssais commented Dec 16, 2019

fwiw there was a release recently.

Patches and hacks and stuff in here should no longer be necessary because I submitted fixes upstream to public-inbox and Xapian while working on packaging this in parallel.

I also have a NixOS module written that I can PR. :)

@catern
Copy link
Contributor Author

@catern catern commented Dec 16, 2019

@alyssais if you have a finished package for the new version I'm happy for that to be submitted instead of this PR. If your packaging isn't ready though I'm also happy to rebase and update the version in this PR.

@alyssais
Copy link
Member

@alyssais alyssais commented Dec 16, 2019

@alyssais alyssais mentioned this pull request Dec 16, 2019
4 of 10 tasks complete
@alyssais alyssais closed this Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.