Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.i3ipc: 1.6.0 -> 1.7.1 #61176

Closed
wants to merge 2 commits into from
Closed

Conversation

@Synthetica9
Copy link
Contributor

Synthetica9 commented May 9, 2019

Motivation for this change

New version was released 2 hours before #61084 was merged, would've included it in that PR otherwise.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Synthetica9 Synthetica9 requested a review from FRidh as a code owner May 9, 2019
@ofborg ofborg bot added the 6.topic: python label May 9, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented May 14, 2019

Result of nix-review pr 61176

5 package were build:
  • i3-wk-switch
  • python27Packages.i3ipc
  • python27Packages.py3status
  • python37Packages.i3ipc
  • python37Packages.py3status

but

$ ./results/i3-wk-switch/bin/i3-wk-switch
Fatal Python error: initsite: Failed to import the site module
Traceback (most recent call last):
  File "/nix/store/2jh8bf3k21hkc7agik6idy5mjr2yljrx-python2.7-setuptools-41.0.1/lib/python2.7/site-packages/site.py", line 73, in <module>
    __boot()
  File "/nix/store/2jh8bf3k21hkc7agik6idy5mjr2yljrx-python2.7-setuptools-41.0.1/lib/python2.7/site-packages/site.py", line 26, in __boot
    import imp  # Avoid import loop in Python 3
  File "/nix/store/zracigqmjvybwpyvpk4g52iajs6ksp31-python3-3.7.3/lib/python3.7/imp.py", line 27, in <module>
    import tokenize
  File "/nix/store/zracigqmjvybwpyvpk4g52iajs6ksp31-python3-3.7.3/lib/python3.7/tokenize.py", line 33, in <module>
    import re
  File "/nix/store/zracigqmjvybwpyvpk4g52iajs6ksp31-python3-3.7.3/lib/python3.7/re.py", line 143, in <module>
    class RegexFlag(enum.IntFlag):
AttributeError: module 'enum' has no attribute 'IntFlag'

I'm not using i3 but I expected the standard usage message as in :

$ /nix/store/xy8dbmqzrlmm83qgp1zp21z052d5vifq-i3-wk-switch-2017-08-21/bin/i3-wk-switch
Usage: /nix/store/xy8dbmqzrlmm83qgp1zp21z052d5vifq-i3-wk-switch-2017-08-21/bin/i3-wk-switch WORKSPACE_NUM
@FRidh
Copy link
Member

FRidh commented Feb 9, 2020

@Synthetica9 will you continue with this PR?

@ryantm
Copy link
Member

ryantm commented Jun 29, 2020

The author hasn't responded and there are merge conflicts now. Please feel free to open again later after fixing!

@ryantm ryantm closed this Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.