Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm8: handle clangStdenv better #61210

Closed

Conversation

@matthewbauer
Copy link
Member

@matthewbauer matthewbauer commented May 9, 2019

Partly addresses #61205. Handles the clang+binutils cross case.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Partly addresses #61205. Handles the clang+binutils cross case.
@prusnak
Copy link
Member

@prusnak prusnak commented May 9, 2020

Do we still want this change? It's been 1 year since it's been open.

@matthewbauer
Copy link
Member Author

@matthewbauer matthewbauer commented May 9, 2020

Closing for now - it may be useful in the future, but has not been tested against master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.