Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help fix quodlibet! (Doesn't find icons) #61219

Closed
wants to merge 1 commit into from
Closed

Conversation

@Zer0-
Copy link
Contributor

@Zer0- Zer0- commented May 10, 2019

The Quodlibet music player hasn't been building.
I got two of the 6 failing tests to pass
but the ones for icons still fail, and in fact adding doCheck = false and running it shows that the app has no icons.

Does anyone versed in gtk know why this is?

Motivation for this change

I like quodlibet and want it to work

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

-The tests for icons fail and the app contains no icons
@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented May 10, 2019

hicolor-icon-theme does not really contain any icons, users are expected to choose an icon theme and install it globally (though some prefer to include Adwaita to make the icons work even for users without icon theme, see discussion on #43150.)

Not really sure why tray icon tests are failing and will not be able to debug anytime soon. Maybe @lazka will have some idea.

@lazka
Copy link

@lazka lazka commented May 10, 2019

Looks like librsvg is missing or the gdk-pixbuf svg loader it contains.

@Zer0-
Copy link
Contributor Author

@Zer0- Zer0- commented May 10, 2019

It also complains that it can't import pyflakes and pycodestyle, however those are added to checkInputs. I wonder why that is.

@lazka
Copy link

@lazka lazka commented May 10, 2019

You can pass --no-quality to test to skip them.

@sauyon
Copy link
Member

@sauyon sauyon commented Jul 15, 2019

I suspect we should be wrapping the tests with a la wrapGAppsHook before running them.

Also, passing --no-quality sounds like a reasonable idea (I assume those are just code quality checks, which shouldn't be relevant for us).

I'm also getting a ton of deprecation warnings, which I hope will go away with 1.13.0.

EDIT: Also mentioning #53938, so this is easy to find.

@101100 101100 mentioned this pull request Jan 16, 2020
4 of 10 tasks complete
@101100
Copy link
Contributor

@101100 101100 commented Feb 3, 2020

This was done in #77796 and can be closed.

@Zer0-
Copy link
Contributor Author

@Zer0- Zer0- commented Feb 4, 2020

safe

@Zer0- Zer0- closed this Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.