Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leptonica: enable tests on non-darwin #61259

Closed
wants to merge 1 commit into from

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented May 11, 2019

Motivation for this change

Enable tests for leptonica - 1.78.0's tests don't seem to behave themselves at all on darwin though, so exclude that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b c0bw3b self-assigned this May 11, 2019
@c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented May 11, 2019

Done in 253dae1

The errors from https://hydra.nixos.org/build/93460995/log seems quite legit.
Makes me wonder whether the lib really is fully usable on darwin

@c0bw3b c0bw3b closed this May 11, 2019
c0bw3b added a commit that referenced this issue May 11, 2019
18 tests failed with errors like:
> Error in callSystemDebug: iOS 11 does not support system()
> Error in fopenReadStream: file not found

Closes #61259
@risicle
Copy link
Contributor Author

@risicle risicle commented May 11, 2019

That's interesting - on my macos 10.13 machine the tests all fail.

I wonder if DanBloomberg/leptonica#431 might fix this for hydra. I tried it for my machine, no effect, but hydra's errors seem far more in that PR's vein.

@c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented May 11, 2019

It seems close indeed. The next release might be fully testable on macOS I presume.

@vjeranc
Copy link

@vjeranc vjeranc commented May 11, 2019

This is the output on my machine, with my fix applied. I had to have gnuplot installed.

My interpretation of the output is that all tests pass.

@risicle
Copy link
Contributor Author

@risicle risicle commented May 11, 2019

:scratch head: mmmyeah? They don't make it easy with the output do they?

@vjeranc
Copy link

@vjeranc vjeranc commented May 11, 2019

Just search for Error and all mentions say to ignore the error.

shinedog pushed a commit to shinedog/nixpkgs that referenced this issue May 11, 2019
18 tests failed with errors like:
> Error in callSystemDebug: iOS 11 does not support system()
> Error in fopenReadStream: file not found

Closes NixOS#61259
tadeokondrak added a commit to tadeokondrak/nixpkgs that referenced this issue May 17, 2019
18 tests failed with errors like:
> Error in callSystemDebug: iOS 11 does not support system()
> Error in fopenReadStream: file not found

Closes NixOS#61259
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants