Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lz4: fix build on darwin #61260

Closed
wants to merge 1 commit into from
Closed

lz4: fix build on darwin #61260

wants to merge 1 commit into from

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented May 11, 2019

Motivation for this change

Fix build on darwin by fetching patch from upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

by fetching patch from upstream
@dtzWill
Copy link
Member

@dtzWill dtzWill commented May 11, 2019

This is same fix over on #60849, right? Not sure where things ended with that, @matthewbauer do you know? :)

@risicle
Copy link
Contributor Author

@risicle risicle commented May 11, 2019

God damn I didn't check staging again.

@risicle risicle closed this May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants