Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto-contrib: init at 0.9.0 #61261

Merged
merged 1 commit into from May 11, 2019
Merged

Conversation

@kalbasit
Copy link
Member

@kalbasit kalbasit commented May 11, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kalbasit
Copy link
Member Author

@kalbasit kalbasit commented May 11, 2019

Waiting for a license to be announced upstream.

@kalbasit kalbasit force-pushed the nixpkgs_add-proto-contrib branch from bdaa5fb to 8b2c62d May 11, 2019
@kalbasit kalbasit changed the title proto-contrib: init at 2019-02-06 proto-contrib: init at 0.9.0 May 11, 2019
@kalbasit kalbasit marked this pull request as ready for review May 11, 2019
@kalbasit
Copy link
Member Author

@kalbasit kalbasit commented May 11, 2019

@GrahamcOfBorg build proto-contrib

@kalbasit kalbasit force-pushed the nixpkgs_add-proto-contrib branch from 8b2c62d to d574f32 May 11, 2019
@kalbasit
Copy link
Member Author

@kalbasit kalbasit commented May 11, 2019

@GrahamcOfBorg eval
@GrahamcOfBorg build proto-contrib

@kalbasit kalbasit merged commit 7977977 into NixOS:master May 11, 2019
16 checks passed
@kalbasit kalbasit deleted the nixpkgs_add-proto-contrib branch May 11, 2019
tadeokondrak added a commit to tadeokondrak/nixpkgs that referenced this issue May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant