Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

youtube-dl: 2019.04.30 -> 2019.05.11 #61264

Merged
merged 1 commit into from May 12, 2019
Merged

Conversation

@xrelkd
Copy link
Contributor

@xrelkd xrelkd commented May 11, 2019

Motivation for this change

Update youtube-dl to the latest release.
https://github.com/ytdl-org/youtube-dl/releases/tag/2019.05.11
NOTE: Updates to youtube-dl should be backported, thanks!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Lassulus
Copy link
Member

@Lassulus Lassulus commented May 12, 2019

tested without nix-review (maybe some python mixup confused it) and works.

Copy link
Contributor

@worldofpeace worldofpeace left a comment

No regressions noticed.

@worldofpeace worldofpeace merged commit 5b49567 into NixOS:master May 12, 2019
13 checks passed
@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented May 12, 2019

backported in 7ab08db

@xrelkd xrelkd deleted the update/youtube-dl branch May 13, 2019
@xrelkd
Copy link
Contributor Author

@xrelkd xrelkd commented May 13, 2019

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented May 13, 2019

Right back to you @xrelkd 💮

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants