Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

youtube-dl: 2019.04.30 -> 2019.05.11 #61264

merged 1 commit into from May 12, 2019


Copy link

@xrelkd xrelkd commented May 11, 2019

Motivation for this change

Update youtube-dl to the latest release.
NOTE: Updates to youtube-dl should be backported, thanks!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits

Copy link

tested without nix-review (maybe some python mixup confused it) and works.

Copy link

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No regressions noticed.

@worldofpeace worldofpeace merged commit 5b49567 into NixOS:master May 12, 2019
Copy link

backported in 7ab08db

@xrelkd xrelkd deleted the update/youtube-dl branch May 13, 2019 02:26
Copy link
Contributor Author

xrelkd commented May 13, 2019

@Fuuzetsu @Lassulus @worldofpeace Thank you!

Copy link

Right back to you @xrelkd 💮

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants