Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

up: 0.3.1 -> 0.3.2 #61281

Merged
merged 2 commits into from May 12, 2019
Merged

up: 0.3.1 -> 0.3.2 #61281

merged 2 commits into from May 12, 2019

Conversation

@Ma27
Copy link
Member

@Ma27 Ma27 commented May 11, 2019

Motivation for this change

New release with several new keyboard shortcuts to navigate between
piped commands: https://github.com/akavel/up/releases/tag/v0.3.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

New release with several new keyboard shortcuts to navigate between
piped commands: https://github.com/akavel/up/releases/tag/v0.3.2
Copy link
Contributor

@marsam marsam left a comment

looks like up uses go modules, would you mind updating it to buildGoModule?

Copy link
Contributor

@tomberek tomberek left a comment

Just a data point: builds and runs on Ubuntu. No reverse dependencies.

Go modules[1] provide a set of sources and corresponding checksums.
These sources can be resolved automatically with Nix, so no go2nix is
required anymore.

[1] https://blog.golang.org/using-go-modules
@Ma27
Copy link
Member Author

@Ma27 Ma27 commented May 12, 2019

@marsam done :)

@ofborg ofborg bot requested a review from kalbasit May 12, 2019
marsam
marsam approved these changes May 12, 2019
@kalbasit kalbasit merged commit 9a0fcca into NixOS:master May 12, 2019
16 checks passed
@Ma27 Ma27 deleted the bump-up branch May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants