Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlitebrowser: 3.10.1 -> 3.11.2 #61287

Merged
merged 1 commit into from May 23, 2019
Merged

sqlitebrowser: 3.10.1 -> 3.11.2 #61287

merged 1 commit into from May 23, 2019

Conversation

@Ma27
Copy link
Member

@Ma27 Ma27 commented May 11, 2019

Motivation for this change

The latest releases of sqlitebrowser contain several new features like
a dark mode, improved CSV import/export and a lot of new bugfixes:

https://github.com/sqlitebrowser/sqlitebrowser/releases/tag/v3.11.2
https://github.com/sqlitebrowser/sqlitebrowser/releases/tag/v3.11.1
https://github.com/sqlitebrowser/sqlitebrowser/releases/tag/v3.11.0

Also some minor changes were applied to the package definition:

  • Using the pname/version convention now.
  • Use internal qscintilla rather than our package to fix the build
    (sqlitebrowser/sqlitebrowser#1348 (comment)).
    This can probably be removed when #56034 is merged.
  • Dropped patch which removed Test and Print support as QT 5.12 is now
    used to build the application.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The latest releases of `sqlitebrowser` contain several new features like
a dark mode, improved CSV import/export and a lot of new bugfixes:

https://github.com/sqlitebrowser/sqlitebrowser/releases/tag/v3.11.2
https://github.com/sqlitebrowser/sqlitebrowser/releases/tag/v3.11.1
https://github.com/sqlitebrowser/sqlitebrowser/releases/tag/v3.11.0

Also some minor changes were applied to the package definition:

* Using the `pname`/`version` convention now.
* Use internal `qscintilla` rather than our package to fix the build
  (sqlitebrowser/sqlitebrowser#1348 (comment)).
  This can probably be removed when NixOS#56034 is merged.
* Dropped patch which removed Test and Print support as QT 5.12 is now
  used to build the application.
@Ma27 Ma27 force-pushed the bump-sqlitebrowser branch from 59bc279 to 629edee May 14, 2019
@Ma27
Copy link
Member Author

@Ma27 Ma27 commented May 23, 2019

@FRidh anything else or is this mergeable now? :)

@FRidh FRidh merged commit 731fdbe into NixOS:master May 23, 2019
16 checks passed
@Ma27 Ma27 deleted the bump-sqlitebrowser branch May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants