Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pyaxmlparser: 0.3.13 -> 0.3.15 #61289

Merged
merged 1 commit into from May 12, 2019

Conversation

@Ma27
Copy link
Member

@Ma27 Ma27 commented May 11, 2019

Motivation for this change

Minor bugfix releases with several improvements and more checks for APK
files to parse.

appknox/pyaxmlparser@v0.3.13...v0.3.15

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Minor bugfix releases with several improvements and more checks for APK
files to parse.

appknox/pyaxmlparser@v0.3.13...v0.3.15
@risicle
Copy link
Contributor

@risicle risicle commented May 11, 2019

nox-review checks out for me on non-nixos linux x86_64 and macos 10.13.

@Ma27
Copy link
Member Author

@Ma27 Ma27 commented May 11, 2019

Adding the port to stable label as it's a patch release with some minor fixes that may be helpful for some users on stable.

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented May 11, 2019

It appears they removed a feature in this release appknox/pyaxmlparser@533942b. Are we sure that's good for stable?

@Ma27
Copy link
Member Author

@Ma27 Ma27 commented May 12, 2019

It appears they removed a feature in this release appknox/pyaxmlparser@533942b. Are we sure that's good for stable?

Ouch, you're totally right, sorry! I just had a short look at the history to check if there are some interesting fixes, but totally missed that :/

I'll be more careful next time about that, even semver says about 0.x releases that "Anything may change at any time." (https://semver.org/#semantic-versioning-specification-semver)

@risicle
Copy link
Contributor

@risicle risicle commented May 12, 2019

Even supposed "bugfix" releases need some scrutiny in my experience, as many authors only realize what's a breaking change after it's released.

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented May 12, 2019

@Ma27

It appears they removed a feature in this release appknox/pyaxmlparser@533942b. Are we sure that's good for stable?

Ouch, you're totally right, sorry! I just had a short look at the history to check if there are some interesting fixes, but totally missed that :/

I'll be more careful next time about that, even semver says about 0.x releases that "Anything may change at any time." (https://semver.org/#semantic-versioning-specification-semver)

Yeah, and I think when there's packages like that on stable we can just keep them frozen or backport if needed, since they're not stable yet.

@risicle
Even supposed "bugfix" releases need some scrutiny in my experience, as many authors only realize what's a breaking change after it's released.

Right, and especially here there isn't a changelog just commits to look through.

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Looks good.

@worldofpeace worldofpeace merged commit 8f5c4f6 into NixOS:master May 12, 2019
13 checks passed
@Ma27 Ma27 deleted the bump-pyaxmlparser branch May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants