Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k2pdfopt: patch custom leptonica with security fixes #61302

Merged
merged 1 commit into from May 13, 2019

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented May 11, 2019

Motivation for this change

This is a cross-port of r19.03's #61217 to patch the custom version of leptonica 1.74.4 used by k2pdfopt.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

this is what you get to inherit if you insist on old versions. cross-port
of r19.03's 0861ad5.
@c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented May 13, 2019

Given upstream chose to 'fork' those 3 libs, it would be their job to adapt those security fixes to their hack...
Well it's great you did the job here, nonetheless.

c0bw3b
c0bw3b approved these changes May 13, 2019
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Built and tested

@c0bw3b c0bw3b merged commit 6722aaf into NixOS:master May 13, 2019
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants