Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.spacy: 2.0.18 -> 2.1.3 #61307

Merged
merged 7 commits into from May 18, 2019
Merged

python3Packages.spacy: 2.0.18 -> 2.1.3 #61307

merged 7 commits into from May 18, 2019

Conversation

@danieldk
Copy link
Member

@danieldk danieldk commented May 11, 2019

Motivation for this change

Changes:

https://github.com/explosion/spaCy/releases

The most important change since 2.0.x is support for ELMo/BERT-like pretraining, but there are many other changes that improve spaCy across the board.

Since spaCy has quite many dependencies (that seem to be specific to spaCy), I have bundled all the necessary changes together in this PR, namely:

  • Add the wasabi wheel
  • Add the srsly wheel
  • Add the blis wheel
  • Update thinc 7.0.4

The last commit updates all the models to version 2.1.0, which also adds medium/small models for Greek and a medium-size model for German.

Tested using the analysis example from the spaCy webpage with the English small model.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk danieldk requested a review from FRidh as a code owner May 11, 2019
@danieldk
Copy link
Member Author

@danieldk danieldk commented May 11, 2019

@GrahamcOfBorg build python3Packages.spacy python3Packages.spacy_models.de_core_news_md python3Packages.spacy_models.de_core_news_sm python3Packages.spacy_models.el_core_news_md python3Packages.spacy_models.el_core_news_sm python3Packages.spacy_models.en_core_web_lg python3Packages.spacy_models.en_core_web_md python3Packages.spacy_models.en_core_web_sm python3Packages.spacy_models.en_vectors_web_lg python3Packages.spacy_models.es_core_news_md python3Packages.spacy_models.es_core_news_sm python3Packages.spacy_models.fr_core_news_md python3Packages.spacy_models.fr_core_news_sm python3Packages.spacy_models.it_core_news_sm python3Packages.spacy_models.nl_core_news_sm python3Packages.spacy_models.pt_core_news_sm python3Packages.spacy_models.xx_ent_wiki_sm

@danieldk
Copy link
Member Author

@danieldk danieldk commented May 13, 2019

spaCy 2.1.4 has been released in the meanwhile, so I have added a commit to update from 2.1.3 to 2.1.4.

@danieldk
Copy link
Member Author

@danieldk danieldk commented May 14, 2019

@dotlambda Since you reviewed my previous spaCy PRs, any chance that you could review this? (And/or trigger the Darwin build to check that it builds fine too?)

@FRidh
Copy link
Member

@FRidh FRidh commented May 14, 2019

@GrahamcOfBorg build python3Packages.spacy python3Packages.spacy_models.de_core_news_md python3Packages.spacy_models.de_core_news_sm python3Packages.spacy_models.el_core_news_md python3Packages.spacy_models.el_core_news_sm python3Packages.spacy_models.en_core_web_lg python3Packages.spacy_models.en_core_web_md python3Packages.spacy_models.en_core_web_sm python3Packages.spacy_models.en_vectors_web_lg python3Packages.spacy_models.es_core_news_md python3Packages.spacy_models.es_core_news_sm python3Packages.spacy_models.fr_core_news_md python3Packages.spacy_models.fr_core_news_sm python3Packages.spacy_models.it_core_news_sm python3Packages.spacy_models.nl_core_news_sm python3Packages.spacy_models.pt_core_news_sm python3Packages.spacy_models.xx_ent_wiki_sm

@globin globin merged commit d149e44 into NixOS:master May 18, 2019
16 checks passed
@danieldk danieldk deleted the spacy-2.1.3 branch Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants