Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

g2o: init at 2019-04-07 #61344

Merged
merged 1 commit into from May 16, 2019

Conversation

Projects
None yet
2 participants
@lopsided98
Copy link
Contributor

commented May 12, 2019

Motivation for this change

I use this package.

Things done

Add g2o using the latest git revision. g2o does not have regular releases. It has a commit from 2017 tagged as a release, but this was added arbitrarily because someone wanted a release (RainerKuemmerle/g2o#194), so I thought it was better to just use the latest version.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lopsided98 lopsided98 force-pushed the lopsided98:g2o-init branch 2 times, most recently from b56ff6b to ee56f48 May 14, 2019

@aanderse
Copy link
Contributor

left a comment

Just a few minor things which are optional, but I would appreciate if you could change.

Show resolved Hide resolved pkgs/development/libraries/g2o/default.nix Outdated
Show resolved Hide resolved pkgs/development/libraries/g2o/default.nix Outdated
Show resolved Hide resolved pkgs/development/libraries/g2o/default.nix Outdated

@lopsided98 lopsided98 force-pushed the lopsided98:g2o-init branch from ee56f48 to 655e9dc May 15, 2019

@aanderse

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

@GrahamcOfBorg build g2o

@aanderse aanderse merged commit 0b1a96c into NixOS:master May 16, 2019

15 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
g2o on aarch64-linux Success
Details
g2o on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@aanderse

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

@lopsided98 thanks for your contribution! 🎉

@lopsided98 lopsided98 deleted the lopsided98:g2o-init branch May 16, 2019

@lopsided98 lopsided98 referenced this pull request May 18, 2019

Open

g2o: build g2o_viewer, libqglviewer: 2.6.3 -> 2.7.1 #61655

6 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.