Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddcci-driver: init at 0.3.2 #61387

Merged
merged 1 commit into from Jan 4, 2020
Merged

ddcci-driver: init at 0.3.2 #61387

merged 1 commit into from Jan 4, 2020

Conversation

@bricewge
Copy link
Contributor

@bricewge bricewge commented May 12, 2019

Motivation for this change

It adds a linux kernel driver for DDC/CI monitors. With it you can modify the brightness of your external monitor through sysfs, in the same way as with a laptop screen. acpilight is the recommended utility to achieve this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bricewge bricewge force-pushed the bricewge:ddcci-driver-linux branch from 1081149 to 4c468c5 May 13, 2019
Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment

Does it work for you?
I'm having the same issues as many of the others: https://gitlab.com/ddcci-driver-linux/ddcci-driver-linux/issues
I haven't tried the udev rules that people are proposing but doing echo 'ddcci 0x37' | sudo tee /sys/bus/i2c/devices/i2c-<?>/new_device doesn't seem to work for me.

I'm on Linux 5.1.8 with an HP ZR24w connected over an HDMI to DVI adapter and the Intel i915 driver.

Your packaging seems fine, though.

@bricewge
Copy link
Contributor Author

@bricewge bricewge commented Jun 24, 2019

Yes, of course, I'm using it daily through acpilight. Note that I rarely disconnect or reconnect the monitor so I'm not sure if hot-plugging is fail-proof.

Following is the configuration I'm using currently:

  boot.kernelModules = [
    "i2c-dev" # For ddcutil
    "ddcci"
    "ddcci-backlight"
  ];

  users.groups = {
    backlight = { };
    i2c = { }; # For ddcutil
  };

  boot.extraModulePackages = [ pkgs.linuxPackages.ddcci-driver ];

  services.udev.packages = with pkgs; [
    ddcutil
    acpilight
  ];

My setup is Linux 4.19.47 with a Benq GW2765 connected over a DVI to HDMI adpater and the Intel i915 driver.

@ryantm
Copy link
Member

@ryantm ryantm commented Jan 4, 2020

@GrahamcOfBorg build linuxPackages.ddcci-driver

@ryantm ryantm merged commit e7e5fc9 into NixOS:master Jan 4, 2020
19 checks passed
19 checks passed
ddcci-driver on aarch64-linux No attempt
Details
ddcci-driver on x86_64-darwin No attempt
Details
ddcci-driver on x86_64-linux No attempt
Details
linuxPackages.ddcci-driver on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
linuxPackages.ddcci-driver on aarch64-linux Success
Details
linuxPackages.ddcci-driver on x86_64-linux Success
Details
@JohnAZoidberg
Copy link
Member

@JohnAZoidberg JohnAZoidberg commented Jan 4, 2020

Can be updated to v.0.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.