Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
audit: Fix build with pkgsMusl. #61574
Motivation for this change
The previous patches no longer applied to the current code.
Also declare necessary autoconf, automake, libtool dependencies.
Without them, the musl build gets:
endgame left a comment
One question, otherwise LGTM.
This command built fine, and seems to make musl-linked binaries:
I checked that
Alternatively push the patch and autotools bits into a rebuild-avoiding optionalAttrs, but that's pretty ugly. Nevermind, although it's what I did locally to avoid mass-rebuild when poking at this same issue:
(forgive references to 2.8.6, commit messages were written a bit sleepy-minded
Actually looks like I did a hack job of what you've done here ;).
I don't think autotools and friends ever really go in
I'd guess without the tools the build attempts to use the pre-generated configure which works for glibc but since it won't have the changes from the patch it doesn't for musl... does that fit?
As for generating it separately and once regardless of platform details -- in fact, while I don't know it's used much in nixpkgs this is precisely what nix itself does (kinda seen here, details are in plumbing elsewhere: https://github.com/NixOS/nix/blob/master/release.nix#L19 ), it generates a prestine source tarball first (generating the bits) and then uses the result everywhere.
I agree such a migration/change shouldn't be started as part of this PR, but perhaps an RFC or issue or something to discuss? If nothing else it'd be good to fix this before such a discussion concludes ;).