Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cocoapods: 1.6.2 -> 1.7.1 #61906

Merged
merged 2 commits into from Jun 1, 2019

Conversation

@lilyball
Copy link
Member

commented May 22, 2019

Also cocoapods-beta: 1.7.0.rc.2 -> 1.7.1.

Motivation for this change

https://github.com/CocoaPods/CocoaPods/releases/tag/1.7.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

I know cocoapods is usually targeted toward darwin, but I was able build and run pod on x86_64-linux after saying it was able to run on all platforms

[16:35:49] jon@jon-workstation ~/projects/nixpkgs (cocoapods)
$ ./result/bin/pod --version
1.7.0
@lilyball

This comment has been minimized.

Copy link
Member Author

commented May 22, 2019

Thanks for checking! I suspect you can't get much further than checking version though as even just installing Pods relies on Xcode (cocoapods loads Xcode's private frameworks to write out project files for some harebrained reason).

@jonringer

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

Yea, i mean, it's just a ruby tool, so the tool itself makes sense it can run on linux. But just after that, it becomes very platform specific. Just thought it was funny.

@lilyball lilyball force-pushed the lilyball:cocoapods branch from b6eca65 to 0f9c140 May 30, 2019

@lilyball lilyball changed the title cocoapods: 1.6.2 -> 1.7.0 cocoapods: 1.6.2 -> 1.7.1 May 30, 2019

@lilyball

This comment has been minimized.

Copy link
Member Author

commented May 30, 2019

Updated to 1.7.1, which was just released today.

@nixos-discourse

This comment has been minimized.

Copy link

commented May 31, 2019

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/8

@matthewbauer matthewbauer merged commit 8b2b0f7 into NixOS:master Jun 1, 2019

13 of 15 checks passed

cocoapods, cocoapods-beta on aarch64-linux No attempt
Details
cocoapods, cocoapods-beta on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@lilyball lilyball deleted the lilyball:cocoapods branch Jun 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.