Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/mlmmj: add more list headers #62160

Open
wants to merge 1 commit into
base: master
from

Conversation

@fgaz
Copy link
Member

commented May 28, 2019

Motivation for this change

since we already add a couple of default headers, it makes sense to have
a sensible default and add the unsubscribe header and friends

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

since we already add a couple of default headers, it makes sense to have
a sensible default and add the unsubscribe header and friends
@fgaz

This comment has been minimized.

Copy link
Member Author

commented Jun 18, 2019

/cc @edwtjo (maintainer of the package, not sure if they maintain the module too)

@nixos-discourse

This comment has been minimized.

Copy link

commented Sep 1, 2019

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-in-distress/3604/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.