Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wireguard-tools, wireguard-go: add update scripts, wireguard-go: 0.0.20181222 -> 0.0.20190517 #62432

Merged
merged 3 commits into from Jun 2, 2019

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jun 1, 2019

Motivation for this change

This adds updateScripts for both wireguard-tools and wireguard-go. As the kernel uses the src from wireguard-tools, this also applies to wireguard kernel modules.

I verified both scripts by updating to the latest version. wireguard-tools was already up to date, so I manually reverted the bump. wireguard-go was outdated, so I added a commit that updates the package.

I didn't build wireguard-go, will let @GrahamcOfBorg handle that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @zx2c4

@flokli flokli requested review from Mic92 and andir June 1, 2019 20:52
vgo2nix -dir $(nix-build -A wireguard-go.src) -outfile $PWD/pkgs/tools/networking/wireguard-go/deps.nix

if [[ -f $PWD/wireguard-go.log ]];then
rm $PWD/wireguard-go.log
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adisbladis can we teach vgo2nix to not write a log file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flokli
Copy link
Contributor Author

flokli commented Jun 1, 2019

@GrahamcOfBorg build wireguard-go

Copy link
Contributor

@zx2c4 zx2c4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

pkgs/tools/networking/wireguard-go/deps.nix Show resolved Hide resolved
@flokli flokli merged commit f712061 into NixOS:master Jun 2, 2019
@flokli flokli deleted the wireguard-update-scripts branch June 2, 2019 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants