Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caja-dropbox: fix python dependency #62617

Merged
merged 1 commit into from Jun 11, 2019

Conversation

@alexarice
Copy link
Contributor

commented Jun 3, 2019

Motivation for this change

Fixes #62612
This seems to fix the issue though I don't know much about python packaging so I don't know if what I have done is correct.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@romildo

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

@GrahamcOfBorg build mate.caja-dropbox

@romildo

romildo approved these changes Jun 4, 2019

Copy link
Contributor

left a comment

  • reviewed the diff and commit messages
  • made sure local build succeeded
  • run nix-review without any failures
@jtojnar

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

Perhaps you might not want pygobject except for build (see #60752)

@alexarice

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

Perhaps you might not want pygobject except for build (see #60752)

So pygobject and gobject-introspection should be in native build inputs?

@jtojnar

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

If the package is synchronized with nautilus-dropbox (dropbox-cli in Nixpkgs). I did not actually checked the fork did not diverge.

@alexarice

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

I don't know much about the project, I just added things until it built. I know that pygobject and gobject-introspection are definitely needed during the build.

@alexarice alexarice force-pushed the alexarice:caja-dropbox branch from f3134c5 to 99d97c9 Jun 5, 2019

@alexarice

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

The packages look virtually identical so I have the changed the dependencies to look like nautilus-dropbox

@ofborg ofborg bot requested a review from romildo Jun 5, 2019

@alexarice

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

@romildo @jtojnar is this ok now?

@jtojnar

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

Hmm, the package actually does not obtain Dropbox from Nix. Either it needs to do so with a patch like nautilus-dropbox does, or it will require pygobject & gtk at runtime to download it.

@alexarice

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

I'll include a patch

@alexarice alexarice force-pushed the alexarice:caja-dropbox branch 3 times, most recently from d447447 to 39c1685 Jun 5, 2019

@alexarice

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

Hopefully this is fixed now though I don't really know a good way to test if an input was correctly put as a nativeBuildInput or buildInput

@jtojnar

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

You can add strictDeps = true to the derivation to enable the distinction.

@alexarice

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

It all works with strictDeps on, should I include strictDeps in the derivation or is it unnecessary

@alexarice alexarice force-pushed the alexarice:caja-dropbox branch from 39c1685 to c740e2a Jun 6, 2019

@alexarice

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2019

I have put in the strictDeps = true line as it everything appears to work correctly with it there

@jtojnar

jtojnar approved these changes Jun 6, 2019

@nixos-discourse

This comment has been minimized.

Copy link

commented Jun 11, 2019

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/16

@romildo romildo merged commit 7f6f5e0 into NixOS:master Jun 11, 2019

13 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@alexarice alexarice deleted the alexarice:caja-dropbox branch Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.