Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-quick-stats: init at 2.0.8 #62730

Closed
wants to merge 2 commits into from

Conversation

@wiedzmin
Copy link

commented Jun 5, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wiedzmin wiedzmin force-pushed the wiedzmin:master branch from 0e084eb to 0afe3fe Jun 5, 2019

src = fetchFromGitHub {
owner = "arzzen";
repo = pname;
rev = "c11bce17bdb1c7f1272c556605b48770646bf807";

This comment has been minimized.

Copy link
@jtojnar

jtojnar Jun 5, 2019

Contributor

This will make future updates easier:

Suggested change
rev = "c11bce17bdb1c7f1272c556605b48770646bf807";
rev = version;

This comment has been minimized.

Copy link
@wiedzmin

wiedzmin Jun 5, 2019

Author

Oh, missed existing tag, thanks!

This comment has been minimized.

Copy link
@jtojnar

jtojnar Jun 5, 2019

Contributor

Does not seem to be resolved

wiedzmin added some commits Jun 5, 2019

@wiedzmin wiedzmin force-pushed the wiedzmin:master branch from 0afe3fe to 8d1374b Jun 5, 2019

@devhell

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2019

Is this a duplicate of #62440?

@vcunat

This comment has been minimized.

Copy link
Member

commented Jun 9, 2019

It is... so if you still want to improve the merged expression in some way (e.g. add yourself to maintainers), I suggest you rebase or start over and force-push this branch.

@wiedzmin

This comment has been minimized.

Copy link
Author

commented Jun 12, 2019

Tool emerged in nixos-unstable branch by another path, so I'm closing this PR, as I had no time to address it in recent days. Anyway thanks you all for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.