Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bash completions for ZFS. #62986

Merged
merged 2 commits into from Jun 12, 2019

Conversation

Projects
None yet
3 participants
@caadar
Copy link
Contributor

commented Jun 11, 2019

Motivation for this change

zfs and zpool commands bash completion support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@@ -130,6 +130,9 @@ let
# Remove tests because they add a runtime dependency on gcc
rm -rf $out/share/zfs/zfs-tests
# Add Bash completions.
install -v -m444 -D contrib/bash_completion.d/zfs $out/etc/bash_completion.d/zfs

This comment has been minimized.

Copy link
@marsam

marsam Jun 12, 2019

Contributor
Suggested change
install -v -m444 -D contrib/bash_completion.d/zfs $out/etc/bash_completion.d/zfs
install -v -m444 -D -t $out/share/bash-completion/completions contrib/bash_completion.d/zfs

the advantage of using $out/share/bash-completion/completions is that bash loads those on demand.
Besides that, LGTM

@matthewbauer matthewbauer merged commit 57301d9 into NixOS:master Jun 12, 2019

13 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@marsam marsam referenced this pull request Jun 12, 2019

Merged

zfs: fix install completions #63047

3 of 10 tasks complete

rydnr pushed a commit to rydnr/nixpkgs that referenced this pull request Jun 13, 2019

Add Bash completions for ZFS. (NixOS#62986)
* Add Bash completions for ZFS.

* Load completions on demand only.

dmvianna added a commit to dmvianna/nixpkgs that referenced this pull request Jun 25, 2019

Add Bash completions for ZFS. (NixOS#62986)
* Add Bash completions for ZFS.

* Load completions on demand only.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.