Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix-synapse: 0.99.5.2 -> 1.0.0 #62990

Merged
merged 1 commit into from Jun 12, 2019

Conversation

Projects
None yet
5 participants
@fpletz
Copy link
Member

commented Jun 11, 2019

Motivation for this change

https://matrix.org/blog/2019/06/11/synapse-1-0-0-released
https://matrix.org/blog/2019/06/11/introducing-matrix-1-0-and-the-matrix-org-foundation

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fpletz fpletz requested a review from Ekleog Jun 11, 2019

@Ekleog

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

This might come with need of changes to the NixOS module, there is at least a new federation_verify_certificates parameter. Following the spirit of NixOS/rfcs#42 we might rather deprecate all the options, but discussion over there isn't over yet, so maybe not deprecate now if the final decision is in the other direction in the end.

What do you think about this question?

@Ekleog

Ekleog approved these changes Jun 11, 2019

@Ekleog

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

Oh and:

@GrahamcOfBorg build nixosTests.matrix-synapse

@fpletz

This comment has been minimized.

Copy link
Member Author

commented Jun 11, 2019

What do you think about this question?

To be honest, I'm not really fond of NixOS/rfcs#42.

But you're right about the new options. I'll check for new options and add those.

@Ekleog

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

You may want to self-nominate on NixOS/rfcs#42, this would help you discuss it properly :)

@Ralith

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

I don't believe it's necessary to add the new options; I think there are already many options we don't expose, and one more shouldn't block updating.

@fpletz fpletz force-pushed the mayflower:pkg/matrix-synapse-1.0.0 branch from 2478493 to 557c586 Jun 11, 2019

@Ekleog

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

@Ralith Exposing that many options, suggesting we are exposing them all, yet not actually exposing them all is in itself an issue.

Totally agree that doesn't necessarily need to be addressed in this PR, just wanted to start the discussion someplace :)

@mguentner

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

Wouldn't it be easier to expose a minimal set of options and merge the rest using extraConfig that is of type types.attrs;?

I did something similar in the mxisd module: https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/networking/mxisd.nix

It works quite well. Whenever mxisd got an update I only changed my extraConfig instead of changing the module and my config.

@Ralith

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

I'm on board with reducing the complexity of the module, but that's a long-term matter.

@fpletz fpletz merged commit 076b79a into NixOS:master Jun 12, 2019

15 of 16 checks passed

matrix-synapse on x86_64-darwin Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
matrix-synapse on aarch64-linux Success
Details
matrix-synapse on x86_64-linux Success
Details

@fpletz fpletz deleted the mayflower:pkg/matrix-synapse-1.0.0 branch Jun 12, 2019

@Ekleog

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

@mguentner Sounds like something compatible with the current state of RFC42, which you may want to comment over there so that it gets an additional data point :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.