Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.cmd2_8: remove #62998

Merged
merged 1 commit into from Jun 12, 2019

Conversation

Projects
None yet
2 participants
@risicle
Copy link
Contributor

commented Jun 11, 2019

Motivation for this change

I'm not sure what to do about this one - alongside the up-to-date version of pythonPackages.cmd2 we also have pythonPackages.cmd2_8 (0.8.0). It seems we've been keeping this for python 2.7 (see commit message 65b15ba), and indeed cmd2 actually supports py2.7 right up to 0.8.6 (https://github.com/python-cmd2/cmd2/blob/master/CHANGELOG.md#085-april-15-2018).

But unfortunately the recent bump of pyparsing from 2.3.0 to 2.3.1 (c78bf91) broke even 0.8.6's tests (probably because of https://github.com/pyparsing/pyparsing/blob/2809cc975277e5b8c9160e1bac903d414eab305d/CHANGES#L100). So we'd either have to disable more tests than I'd like or maintain an old version of pyparsing too. And seeing as there don't actually seem to be any in-tree reverse dependencies of cmd2_8, it seems most sensible to just remove it - we can't go on offering a whole parallel package selection for 2.7...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle risicle force-pushed the risicle:ris-rm-cmd2-old branch from bff6e8b to 04ea5e4 Jun 11, 2019

@risicle

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2019

cc @teto

@teto

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

some attempted to fix the tests previously but as no package depends on it and it's python2 (come on), I am all for removing it.

@teto teto merged commit 0d576d7 into NixOS:master Jun 12, 2019

12 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.