Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infix: init at 1.2 #63010

Closed
wants to merge 4 commits into from

Conversation

Projects
None yet
2 participants
@dmvianna
Copy link
Contributor

commented Jun 12, 2019

Motivation for this change

New package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

sha256 = "a1bfdcf875bc072f41e426d0673f2e3017750743bb90cc725fffb292eb09648c";
};

doCheck = true;

This comment has been minimized.

Copy link
@FRidh

FRidh Jun 15, 2019

Member

not needed

doCheck = false; # tests written in Python 2; library compiles and runs properly otherwise.
buildInputs = with pkgs; [ glibcLocales ];
propagatedBuildInputs = with pythonPackages; [ pytest coverage ];
preConfigure = ''

This comment has been minimized.

Copy link
@FRidh

FRidh Jun 15, 2019

Member

I don't think this is needed anymore

sha256 = "06136f03d5b361718b8d0d234042f7b2f203910d8568f63df2f866b547b3d4b9";
};

doCheck = true;

This comment has been minimized.

Copy link
@FRidh

FRidh Jun 15, 2019

Member

not needed

@@ -0,0 +1,33 @@
{ pkgs

This comment has been minimized.

Copy link
@FRidh

FRidh Jun 15, 2019

Member

don't pass in pkgs. Pass in actual packages instead

@@ -0,0 +1,33 @@
{ pkgs
, lib
, pythonPackages

This comment has been minimized.

Copy link
@FRidh

FRidh Jun 15, 2019

Member

don't pass in pythonPackages. Pass in actual packages instead.

@@ -0,0 +1,29 @@
{ lib
, pkgs

This comment has been minimized.

Copy link
@FRidh

FRidh Jun 15, 2019

Member

as before

@@ -0,0 +1,29 @@
{ lib
, pkgs
, pythonPackages

This comment has been minimized.

Copy link
@FRidh

FRidh Jun 15, 2019

Member

as before

@dmvianna

This comment has been minimized.

Copy link
Contributor Author

commented Jun 16, 2019

Sorry @FRidh, this PR is a duplicate, and I could not find it before you spent time reviewing it. The packages being submitted here were reviewed in #63075 and #63007.

Thanks for your effort.

@dmvianna dmvianna closed this Jun 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.