Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox: 67.0.1 -> 67.0.2 #63016

Merged
merged 1 commit into from Jun 13, 2019

Conversation

Projects
None yet
4 participants
@dtzWill
Copy link
Contributor

commented Jun 12, 2019

Motivation for this change

I believe this is updated by someone else regularly,
but noticed and was curious so submitting in case
it's useful. Simple the result of running the updateScript's
for these :).

https://www.mozilla.org/en-US/firefox/67.0.2/releasenotes/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vcunat

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

I suppose noone has an idea why I'm repeatedly getting write error: stdout errors during build? (again but elsewhere) I don't seem to be exhausting any resources here.

@edolstra

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

@vcunat Is that on Hydra? Might be related to NixOS/nix#2878.

@vcunat

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

No, it's just nix build invocation, happening both over NIX_REMOTE=ssh-ng:// and directly on that machine. EDIT: it's not a NixOS, so it's theoretically possible I haven't set up something ideally.

@andir

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

It is an upstream issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1500436

Try building with at most 10 cores. Sometimes I have to go as low as 4. It really seems like a timing issues with some concurrent jobs.

The workaround mentioned in the bugzilla report (adding -v) didn't work for me when I tried.

@vcunat

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

I have a wild suspicion that when many processes write into a shared stream (stdout+stderr), they might sometimes get an EAGAIN or something... but generally this is so rare that much SW can't handle the error.

@andir

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

I had similar thought just never tried to debug it.. On hydra it seems to work just fine (most of the time) since the hosts either are busy enough or are not running a high amount of parallel builds.

I am wondering if we can just increase some amount of buffer space on the sockets (from within GNU make)?

@vcunat

vcunat approved these changes Jun 12, 2019

Copy link
Member

left a comment

Both seem to work fine on a quick test. The NEWS sound safe, and minor FF updates tend to be rather problem-free. Surprisingly I can't see any security fixes in there.

@andir

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

Surprisingly I can't see any security fixes in there.

They are lacking behind these days. Sometimes it takes them hours/days to publish them and then a bit more time to crosslink: https://www.mozilla.org/en-US/security/advisories/mfsa2019-16/

@vcunat

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

I don't know... also I wonder why we haven't experienced this with other packages so far, right? For example, I was building the kernel on this 32-threaded machine (that was otherwise idle).

@vcunat vcunat referenced this pull request Jun 12, 2019

Closed

firefox, firefox-bin: 67.0.1 -> 67.0.2 #63031

4 of 10 tasks complete

@vcunat vcunat merged commit 762f89d into NixOS:master Jun 13, 2019

13 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

vcunat added a commit that referenced this pull request Jun 13, 2019

vcunat added a commit that referenced this pull request Jun 14, 2019

Merge #63016: firefox: 67.0.1 -> 67.0.2
(cherry picked from commit 3e54aaa)
There are also some less sever security fixes:
https://www.mozilla.org/en-US/security/advisories/mfsa2019-16/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.