Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

midisheetmusic: always bring timidity dependency #63024

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@gnidorah
Copy link
Contributor

commented Jun 12, 2019

Motivation for this change

Currently after system upgrade, if midisheetmusic is got from binary cache, it shows The Timidity MIDI player is not installed error. This is because timidity is not present in nix store at user side. So add it to buildInputs to always bring that dependency.

Instead of #53813 cc @FRidh

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.