Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: 1.12.5->1.12.6, 1.11.10->1.11.11 #63035

Merged
merged 17 commits into from Jun 12, 2019

Conversation

Projects
None yet
@rvolosatovs
Copy link
Contributor

commented Jun 12, 2019

Motivation for this change

Upstream update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Izorkin and others added some commits Jun 6, 2019

nixos-generate-config: add support for bcache
Add "bcache" to boot.initrd.availableKernelModules if a bcache device is
detected.

This fixes a problem I've had one too many times: I install NixOS and
forget to add "bcache", resulting in an unbootable machine (until fixed
with Live CD). Now NixOS will do it for me.
xorg.xcalc: 1.0.7 -> 1.1.0
xcalc: ensure "app-defaults" resources are installed+found, works now
browsh: 1.5.0 -> 1.5.2
* update/regen deps.nix
bitlbee-discord: set BITLBEE_DATADIR
Build fails otherwise

Signed-off-by: William Casarin <jb55@jb55.com>
bitlebee-discord: add myself as maintainer
Signed-off-by: William Casarin <jb55@jb55.com>
Merge pull request #62966 from bjornfor/nixos-generate-config-bcache
nixos-generate-config: add support for bcache
Merge pull request #62783 from Izorkin/php-packages
php: update build config and php package
@adisbladis

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

@GrahamcOfBorg build go_1_11 go_1_12 go-ethereum

@kalbasit kalbasit changed the base branch from master to staging Jun 12, 2019

@kalbasit kalbasit merged commit da3ec20 into NixOS:staging Jun 12, 2019

17 of 18 checks passed

grahamcofborg-eval Cloning project
Details
Evaluation Performance Report Evaluator Performance Report
Details
go on aarch64-linux Success
Details
go on x86_64-linux Success
Details
go-ethereum, go_1_11, go_1_12 on aarch64-linux Success
Details
go-ethereum, go_1_11, go_1_12 on x86_64-darwin Success
Details
go-ethereum, go_1_11, go_1_12 on x86_64-linux Success
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@ofborg ofborg bot removed the 6.topic: golang label Jun 12, 2019

@rvolosatovs

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

Looks like a bunch of commits was added to the PR when it was merged, was that expected?

@rvolosatovs rvolosatovs deleted the rvolosatovs:update/go branch Jun 12, 2019

@adisbladis

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

@rvolosatovs This is because @kalbasit changed the target branch to staging instead of master.
Any commit from master that was not already in staging went along for the ride.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.