Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.flask_script: fix hash #63036

Merged
merged 1 commit into from Jun 13, 2019

Conversation

Projects
None yet
3 participants
@ajs124
Copy link
Contributor

commented Jun 12, 2019

the old hash was for 2.0.5, so the store path for the dist-info was:
/nix/store/v5sgpkxpp950chzdzzj4b5yl9r0w0by7-python3.7-Flask-Script-2.0.6/lib/python3.7/site-packages/Flask_Script-2.0.5.dist-info

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ajs124 ajs124 requested a review from FRidh as a code owner Jun 12, 2019

@ofborg ofborg bot added the 6.topic: python label Jun 12, 2019

@ofborg ofborg bot requested a review from abbradar Jun 12, 2019

@knedlsepp
Copy link
Contributor

left a comment

Please remove the "sha256:" part.

@ajs124 ajs124 force-pushed the ajs124:flask_script_fix branch from 9b97d2c to 089490d Jun 12, 2019

@ajs124

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

Done. But why?

pythonPackages.flask_script: fix hash
the old hash was for 2.0.5, so the store path for the dist-info was:
/nix/store/v5sgpkxpp950chzdzzj4b5yl9r0w0by7-python3.7-Flask-Script-2.0.6/lib/python3.7/site-packages/Flask_Script-2.0.5.dist-info
@worldofpeace

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

Because we're not using a sri hash NixOS/nix@6024dc1 and current nix prints hashes in that format by default.

@worldofpeace worldofpeace force-pushed the ajs124:flask_script_fix branch from 089490d to 760e394 Jun 13, 2019

@worldofpeace worldofpeace changed the title python.flask_script: fix hash pythonPackages.flask_script: fix hash Jun 13, 2019

@worldofpeace worldofpeace merged commit c3311fb into NixOS:master Jun 13, 2019

1 check was pending

grahamcofborg-eval Cloning project
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.