Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel.nix: boot.vesa implies nomodeset #63090

Merged
merged 1 commit into from Jun 20, 2019
Merged

kernel.nix: boot.vesa implies nomodeset #63090

merged 1 commit into from Jun 20, 2019

Conversation

wmertens
Copy link
Contributor

Without nomodeset the console is reset to 80x25 after Grub.

Motivation for this change

The standard configuration, even with boot.vesa = true, results in a tiny virtual console.

Things done

Tested this configuration on a VM; did not test this actual change.

Without nomodeset the console is reset to 80x25 after Grub
@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/big-virtual-console-solved/3176/3

@wmertens
Copy link
Contributor Author

@7c6f434c You made this configurable 10 years ago, any opinion on this? :)

@7c6f434c
Copy link
Member

I think this was before working kernel mode setting! And before UEFI which affects early initialisation of the display.

(and in the meantime I stopped using this area of NixOS boot code)

I would expect that configuring modeset and fbcon should provide better options than vesa — but I am not sure about virtual machines. I agree that if we do want VESA switching off modeset makes sense.

@matthewbauer matthewbauer merged commit 2b8ea61 into master Jun 20, 2019
@wmertens wmertens deleted the nomodeset branch June 20, 2019 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants