Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skopeo: 0.1.36 -> 0.1.37 #63352

Merged
merged 1 commit into from Aug 3, 2019

Conversation

@vdemeester
Copy link
Member

commented Jun 17, 2019

Motivation for this change

Bump to latest release of skopeo.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

skopeo: 0.1.36 -> 0.1.37
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@vdemeester

This comment has been minimized.

Copy link
Member Author

commented Jun 17, 2019

@GrahamcOfBorg build skopeo

@vdemeester

This comment has been minimized.

Copy link
Member Author

commented Jun 17, 2019

@GrahamcOfBorg test docker-tools

@mmahut
Copy link
Member

left a comment

Not sure why the test failed, but:

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review without any failures
  • run and tested the binaries
@vdemeester

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2019

@NeQuissimus
Copy link
Member

left a comment

Skopeo works, I do get the same test failure locally though

@srhb
Copy link
Contributor

left a comment

Just putting in a red review to avoid accidental merges while trying to figure out the test failure. I think it's critical enough.

@srhb
srhb approved these changes Aug 3, 2019
Copy link
Contributor

left a comment

Nevermind, rebasing on top of master actually removes the error. Phew! 😁

@srhb srhb merged commit c99d704 into NixOS:master Aug 3, 2019

16 of 17 checks passed

tests.docker-tools on x86_64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
skopeo on aarch64-linux Success
Details
skopeo on x86_64-linux Success
Details
tests.docker-tools on aarch64-linux Success
Details

@vdemeester vdemeester deleted the vdemeester:update-skopeo branch Aug 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.