Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qtpbfimageplugin: init at 1.4 #63506

Merged
merged 2 commits into from Jul 12, 2019

Conversation

Projects
None yet
3 participants
@sikmir
Copy link
Contributor

commented Jun 19, 2019

Motivation for this change

Optional dependency for gpxsee that enables support for PBF vector maps.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sikmir

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

@dywedir FYI, gpxsee depends on it.

@sikmir sikmir force-pushed the sikmir:add-qtpbfimageplugin branch from 7d12b5f to f4cb6c3 Jun 20, 2019

@sikmir

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

@jonringer Is there any more todos here? Otherwise, could we land this PR?

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

@GrahamcOfBorg build qtpbfimageplugin

@sikmir sikmir force-pushed the sikmir:add-qtpbfimageplugin branch from f4cb6c3 to 3d8be0d Jun 27, 2019

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

@GrahamcOfBorg build qtpbfimageplugin

@worldofpeace worldofpeace force-pushed the sikmir:add-qtpbfimageplugin branch from 79784b7 to 48e509a Jul 12, 2019

@worldofpeace worldofpeace force-pushed the sikmir:add-qtpbfimageplugin branch from 48e509a to 2c6ba83 Jul 12, 2019

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

@sikmir I've fixed the darwin build for you.

Edit: should have used qmakeFlags settings PROTOBUF. too late now.

We can merge this now 🎊

@worldofpeace worldofpeace merged commit 5c83eae into NixOS:master Jul 12, 2019

1 check was pending

grahamcofborg-eval Checking new out paths
Details

@sikmir sikmir deleted the sikmir:add-qtpbfimageplugin branch Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.