Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/bluetooth: don't install obex tools by default #63607

Merged
merged 2 commits into from Dec 1, 2019

Conversation

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jun 21, 2019

Motivation for this change

Currently setting hardware.bluetooth.enable = true install the OpenOBEX tools along with bluez.
Since sharing files over bluetooth seems pretty uncommon and the packages are more than 200MB I propose we don't install them by default.


@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Jun 21, 2019

Only problem I see here could be like applications relying on obexftp being in the global environment and removing them would break them. (IIRC some plasma related utilities).

@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Jun 21, 2019

BlueZ still has obexd so this is more accurately removing the OpenOBEX related things.

@jtojnar

This comment has been minimized.

Copy link
Contributor

jtojnar commented Jun 21, 2019

If we accept this, it needs to be mentioned in release notes.

@rnhmjoj

This comment has been minimized.

Copy link
Contributor Author

rnhmjoj commented Jun 21, 2019

If we accept this, it needs to be mentioned in release notes.

Done.

@rnhmjoj

This comment has been minimized.

Copy link
Contributor Author

rnhmjoj commented Jul 4, 2019

worldofpeace: do you know more about the plasma situation? If needed this could be installed behind a guard like plasma5.enable.

@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Jul 31, 2019

@rnhmjoj I'm not sure.

Perhaps some maintainers/contributors of plasma5 will know

@bkchr @ttuegel

@rnhmjoj rnhmjoj force-pushed the rnhmjoj:remove-obex branch from f4a5553 to 1598f3d Nov 29, 2019
@rnhmjoj

This comment has been minimized.

Copy link
Contributor Author

rnhmjoj commented Nov 29, 2019

I rebased and moved the note to 20.03. Any update?

@ttuegel

This comment has been minimized.

Copy link
Member

ttuegel commented Dec 1, 2019

If needed this could be installed behind a guard like plasma5.enable.

As far as I know this is still required by Plasma. Could you please put it behind a guard?

@rnhmjoj

This comment has been minimized.

Copy link
Contributor Author

rnhmjoj commented Dec 1, 2019

Thank you @ttuegel. Is this ok?

@ofborg ofborg bot added the 6.topic: qt/kde label Dec 1, 2019
@worldofpeace worldofpeace merged commit 15951cb into NixOS:master Dec 1, 2019
12 checks passed
12 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Copy link
Member

ttuegel left a comment

Perfect. Thanks! 😃

@bjornfor

This comment has been minimized.

Copy link
Contributor

bjornfor commented on 40d4c3c Dec 3, 2019

Why was it removed from the common config and added (only) to plasma5? Should we add this back to all desktop environments separately?

@rnhmjoj

This comment has been minimized.

Copy link
Contributor Author

rnhmjoj commented Dec 3, 2019

Since sharing files over bluetooth seems pretty uncommon and the packages are more than 200MB I propose we don't install them by default.

@bjornfor are you aware of other desktop environments that need these tools?

@bjornfor

This comment has been minimized.

Copy link
Contributor

bjornfor commented Dec 3, 2019

No, I'm not aware of other DEs that need this. I was just worried there were, seeing that commit.

Since sharing files over bluetooth seems pretty uncommon

Personally, sharing files over bluetooth is something I would like to do, if it worked reliably. But I've never good enough experience with bluetooth on linux to rely on it :-/

@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Dec 3, 2019

I checked and it appears it's likely dolphin needed this for that functionality. So it probably won't be that a desktop environment needs, more that a program that uses this functionality will need the packages installed.

@rnhmjoj rnhmjoj deleted the rnhmjoj:remove-obex branch Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.