Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distgen: init at 1.3 #63636

Merged
merged 1 commit into from Jul 12, 2019

Conversation

Projects
None yet
2 participants
@bachp
Copy link
Contributor

commented Jun 21, 2019

Motivation for this change

This tool is mainly used in openshift to build source to image containers.
Building a source to image container required dg to be present.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Member

left a comment

Show resolved Hide resolved pkgs/development/tools/distgen/default.nix
Show resolved Hide resolved pkgs/top-level/all-packages.nix Outdated
Show resolved Hide resolved pkgs/development/tools/distgen/default.nix Outdated
@worldofpeace

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

ping @bachp

@bachp bachp force-pushed the bachp:distgen branch from cbe3d72 to 3d14216 Jul 11, 2019

@bachp

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

@worldofpeace Thanks for reminding me.

I added the unit tests and they seem so to work.

The PR is updated to address all your change requests.

distgen: init at 1.3
This tool is mainly used in openshift to build source to image containers.

@worldofpeace worldofpeace force-pushed the bachp:distgen branch from 3d14216 to 195e30b Jul 12, 2019

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

Force push put the testing dependencies in checkInputs.

@worldofpeace
Copy link
Member

left a comment

LGTM, builds for all interpreters and tests pass.

@worldofpeace worldofpeace merged commit f91c86d into NixOS:master Jul 12, 2019

1 check was pending

grahamcofborg-eval Checking original out paths
Details

@bachp bachp deleted the bachp:distgen branch Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.