Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: add applyOptional field to options, use it in mkAliasOptionModule (fixes #63693) #63719

Closed
wants to merge 1 commit into from

Conversation

@j-piecuch
Copy link

commented Jun 24, 2019

Motivation for this change

This fixes #63693.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@j-piecuch j-piecuch requested review from edolstra and nbp as code owners Jun 24, 2019
@Infinisil

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

Thanks for the issue and PR, I've implemented a better fix in #66407 though, have a look

@j-piecuch

This comment has been minimized.

Copy link
Author

commented Aug 21, 2019

Thanks for the feedback!
Closing due to a better fix pending (#66407).

@j-piecuch j-piecuch closed this Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.