Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ldh_client #63789

Closed
wants to merge 1 commit into from
Closed

ldh_client #63789

wants to merge 1 commit into from

Conversation

@mogorman
Copy link
Contributor

@mogorman mogorman commented Jun 25, 2019

Motivation for this change

ldh_client is a setup helper for https://librem.one currently the program is only useful for auto configuring their vpn connection

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mogorman mogorman requested a review from FRidh as a code owner Jun 25, 2019
@mogorman mogorman force-pushed the mogorman:ldh_client branch 2 times, most recently from 69e6d46 to 8da0333 Jun 25, 2019
@mogorman mogorman force-pushed the mogorman:ldh_client branch from 8da0333 to e3c3dd0 Jul 14, 2019
@mogorman mogorman force-pushed the mogorman:ldh_client branch from e3c3dd0 to 8f8f1e5 Jul 14, 2019
@FRidh
Copy link
Member

@FRidh FRidh commented Jul 17, 2019

Please include pythonPackages. in the commit message.

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Dec 16, 2019

And also please update the PR title.

@FRidh
Copy link
Member

@FRidh FRidh commented Feb 9, 2020

Nothing happening so closing.

@FRidh FRidh closed this Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.