Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deepin.deepin-editor: init at 1.2.9.1 #63845

Merged
merged 1 commit into from Nov 22, 2019

Conversation

@romildo
Copy link
Contributor

@romildo romildo commented Jun 27, 2019

Motivation for this change

Add deepin-editor, a desktop text editor that supports common text editing features.

About packaging deepin for NixOS: #59023

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Jun 30, 2019

So I can never get these applications to draw when installed with nix-env.

Usually get this in the logs

"dtkwidget2" can not find qm files
"deepin-editor" can not find qm files

Seeing that coming from within dtkwidget https://github.com/linuxdeepin/dtkwidget/blob/b1308c8ac3fbf42a1c9204dc07967979bce461cc/src/widgets/dapplication.cpp#L289

So I'm guessing (didn't even read the code) there's some global way of getting translations for each project
that, if not found, doesn't draw the application?

@romildo romildo force-pushed the romildo:upd.deepin.deepin-editor branch from 47e6e40 to 9b09266 Nov 22, 2019
@romildo romildo changed the title deepin.deepin-editor: init at 1.2.9 deepin.deepin-editor: init at 1.2.9.1 Nov 22, 2019
@romildo
Copy link
Contributor Author

@romildo romildo commented Nov 22, 2019

So I can never get these applications to draw when installed with nix-env.

It works for me.

@romildo
Copy link
Contributor Author

@romildo romildo commented Nov 22, 2019

Usually get this in the logs

"dtkwidget2" can not find qm files
"deepin-editor" can not find qm files

Those messages appear even in deepin linux.

@worldofpeace worldofpeace merged commit 2d67023 into NixOS:master Nov 22, 2019
16 checks passed
16 checks passed
deepin.deepin-editor on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
deepin.deepin-editor on aarch64-linux Success
Details
deepin.deepin-editor on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@romildo romildo deleted the romildo:upd.deepin.deepin-editor branch Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.