Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages.undollar:init at 1.0.0 #63935

Closed
wants to merge 1 commit into from
Closed

nodePackages.undollar:init at 1.0.0 #63935

wants to merge 1 commit into from

Conversation

@pasqui23
Copy link
Contributor

@pasqui23 pasqui23 commented Jun 29, 2019

Motivation for this change

Undollar is a simple utility to ease copy-pasting scripting

Things done
  • [ X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [X ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • [ X] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pasqui23 pasqui23 changed the title undollar:init at 1.0.0 nodePackages.undollar:init at 1.0.0 Jun 30, 2019
@prusnak
Copy link
Member

@prusnak prusnak commented May 30, 2020

Please rework your PR. It now has a merge conflict after PR #89184 has been merged

@ryantm
Copy link
Member

@ryantm ryantm commented Oct 16, 2020

merged via #100606

@ryantm ryantm closed this Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants