Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/deluge: add user/group/openFirewall opts and extraction packages to path #64112

Merged
merged 2 commits into from Jul 12, 2019

Conversation

@davidtwco
Copy link
Contributor

commented Jul 2, 2019

Motivation for this change

This PR adds configuration options to the Deluge module that allows
configuration of the user and group that the deluged and delugeweb
daemons run as. It also adds a openFirewall option for the deluge web
interface. Further, it adds extraction utilities used by Deluge's built-in
"Extractor" plugin to the PATH so that Deluge doesn't error and behave
strangely when the plugin is enabled and it can't find them.

I've confirmed this works by importing the module in my local configuration.

cc @Infinisil (reviewed the previous change to the Deluge module)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

nixos/modules/services/torrent/deluge.nix Outdated Show resolved Hide resolved
nixos/modules/services/torrent/deluge.nix Outdated Show resolved Hide resolved

@davidtwco davidtwco force-pushed the davidtwco:deluge/users-groups-firewalls branch from 695a501 to 207ab05 Jul 2, 2019

davidtwco added some commits Jul 1, 2019

nixos/deluge: user, group and web firewall opts.
This commit adds new options to the Deluge service:

- Allow configuration of the user/group which runs the deluged daemon.
- Allow configuration of the user/group which runs the deluge web
  daemon.
- Allow opening firewall for the deluge web daemon.
nixos/deluge: Add extractor dependencies.
This commit adds the "Extractor" plugin dependencies to the PATH of the
`deluged` service.

@davidtwco davidtwco force-pushed the davidtwco:deluge/users-groups-firewalls branch from 207ab05 to 16c394f Jul 2, 2019

@Infinisil
Copy link
Member

left a comment

LGTM

@dtzWill dtzWill referenced this pull request Jul 9, 2019
0 of 10 tasks complete
@davidtwco

This comment has been minimized.

Copy link
Contributor Author

commented Jul 12, 2019

@Infinisil is there anything else I need to do to see this merge?

@Infinisil Infinisil merged commit 5b8b5a6 into NixOS:master Jul 12, 2019

12 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@davidtwco davidtwco deleted the davidtwco:deluge/users-groups-firewalls branch Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.