Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/httpd: module cleanup #64151

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@aanderse
Copy link
Contributor

commented Jul 2, 2019

Motivation for this change

Module cleanup:

  • the port option was deprecated long ago so time to remove entirely
  • mark httpd.extraSubservices as deprecated in favor of real NixOS modules
  • resolve #23120 by removing reference to postgresql.services (which was likely added because of various httpd.extraSubservices which have/will be eliminated)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2019

@GrahamcOfBorg test haproxy
@GrahamcOfBorg test tomcat
@GrahamcOfBorg test upnp

@aanderse

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2019

error: timed out waiting for the VM to connect

All tests run fine here... 🤷‍♂

@aanderse aanderse changed the title Httpd extra subservices nixos/httpd: module cleanup Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.