Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Golang] nix-shell: Symlink src root under package path in GOPATH #64264

Conversation

@ramirez7
Copy link
Contributor

commented Jul 3, 2019

Updated version of : https://github.com/NixOS/nixpkgs/pull/46553/files


Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

This needs reviews from the maintainers of the Go expressions.

@FRidh

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

I suggest you ping them.

@FRidh

This comment has been minimized.

Copy link
Member

commented Aug 3, 2019

Nothing happening so closing.

@FRidh FRidh closed this Aug 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.