Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brave: Add libpulseaudio #64331

Merged
merged 1 commit into from Jul 6, 2019

Conversation

@gloaming
Copy link
Contributor

commented Jul 5, 2019

Motivation for this change

Fixes #63966

Things done
$ nix path-info -S /nix/store/h51l8lmwnmm779sp97zwrq0wciymraw2-brave-0.65.118/
/nix/store/h51l8lmwnmm779sp97zwrq0wciymraw2-brave-0.65.118        640199928

$ nix path-info -S /nix/store/n4v5f7is0fnlq205lbnpnpkp9rrlr6kk-brave-0.65.118
/nix/store/n4v5f7is0fnlq205lbnpnpkp9rrlr6kk-brave-0.65.118        646592456
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xrelkd

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

@GrahamcOfBorg build brave

@xrelkd

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

LGTM!
Tested locally on NixOS.
I can hear the sound when I watch YouTube videos.

My /etc/nixos/configuration.nix:

# /etc/nixos/configuration.nix
{ config, pkgs, ... }:
{
    # Various config stuff ...

    hardware.pulseaudio = {
        enable = true;
        daemon.config = {
              flat-volumes = "no";
        };
        package = pkgs.pulseaudioFull;
        extraModules = [ pkgs.pulseaudio-modules-bt ];
    };

    # Various config stuff ...
}

@worldofpeace worldofpeace merged commit 2a9e034 into NixOS:master Jul 6, 2019

14 of 15 checks passed

brave on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
brave on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@worldofpeace

This comment has been minimized.

Copy link
Member

commented Jul 6, 2019

Thanks @gloaming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.