Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow NetworkManager and wireless together #64364

Open
wants to merge 1 commit into
base: master
from

Conversation

@JohnAZoidberg
Copy link
Member

commented Jul 6, 2019

Motivation for this change

When NetworkManager is configured to not manage all interfaces, it's
perfectly fine to have the rest be managed by the standard nixos
wireless scripts.

I use

  networking.networkmanager.unmanaged = [
    "*" "except:type:wwan" "except:type:gsm"
  ];

to control everything using networking.wireless except for the mobile
LTE modem which only works with NetworkManager.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@@ -173,13 +173,24 @@ in {
'';
};

withSupplicant = mkOption {
internal = true;

This comment has been minimized.

Copy link
@teto

teto Jul 7, 2019

Contributor

Not sure about the internal here. Also we could use a more generic option like "ignoreWireless"/ "delegateWireless" without naming supplicant as there might be other options in the future.

This comment has been minimized.

Copy link
@JohnAZoidberg

JohnAZoidberg Jul 7, 2019

Author Member

I'm not exactly sure about the semantics of internal.
Actually I think I want it to be just a variable.
Is internal like a config option that the user cannot set themself, just the module?
Yeah okay, not calling it supplicant makes sense.

This comment has been minimized.

Copy link
@JohnAZoidberg

JohnAZoidberg Jul 9, 2019

Author Member

I switched to a variable with the name delegateWireless.

@JohnAZoidberg JohnAZoidberg force-pushed the JohnAZoidberg:nm-wireless branch from 8f34186 to 699bb98 Jul 9, 2019

@JohnAZoidberg

This comment has been minimized.

Copy link
Member Author

commented Jul 9, 2019

cc @jtojnar @Mic92 @vcunat because you've commmitted to both the network manager service and the modem-manager package. Maybe you also find it useful for the purpose of using the modem while using networking.wireless.enable.

@JohnAZoidberg JohnAZoidberg force-pushed the JohnAZoidberg:nm-wireless branch 2 times, most recently from 8afa5f5 to 9ab92c1 Jul 30, 2019

networkmanager: Allow NetworkManager and wireless together
When NetworkManager is configured to not manage all interfaces, it's
perfectly fine to have the rest be managed by the standard nixos
wireless scripts.

I use
  networking.networkmanager.unmanaged = [
    "*" "except:type:wwan" "except:type:gsm"
  ];
to control everything using networking.wireless except for the mobile
LTE modem which only works with NetworkManager.

@JohnAZoidberg JohnAZoidberg force-pushed the JohnAZoidberg:nm-wireless branch from 9ab92c1 to 6790ead Aug 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.