Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tt-rss: remove deprecated usage of PermissionsStartOnly, specify a group to run service as, and fix local pgsql database creation #64365

Merged
merged 1 commit into from Jul 20, 2019

Conversation

@aanderse
Copy link
Contributor

commented Jul 6, 2019

Motivation for this change

#55370
#53852
#40437 (partial fix)
#64312 (potential fix?)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ping @edermi @matthiasbeyer @telotortium for testing and review please.

nixos/tt-rss: remove deprecated usage of PermissionsStartOnly, specif…
…y a group to run service as, and fix local pgsql database creation
@matthiasbeyer

This comment has been minimized.

Copy link
Contributor

commented Jul 6, 2019

Can maybe test tomorrow.

@telotortium

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

Tested, works.

@aanderse

This comment has been minimized.

Copy link
Contributor Author

commented Jul 16, 2019

@telotortium Thanks for testing! Did you test on an existing or fresh install? Which database backend did you test?

@telotortium

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

@aanderse aanderse marked this pull request as ready for review Jul 18, 2019

@aanderse

This comment has been minimized.

Copy link
Contributor Author

commented Jul 18, 2019

@edermi If you're on 18.03 there probably isn't a way for you to test this out easily as it is using more than one feature from master... But if you do happen to end up testing this please let us know if it fixes #40437 for you (which I suspect it might).

@aanderse aanderse requested review from yegortimoshenko and flokli Jul 18, 2019

@aanderse

This comment has been minimized.

Copy link
Contributor Author

commented Jul 20, 2019

Merging based on testing from @telotortium. Thanks!

@aanderse aanderse merged commit faf884c into NixOS:master Jul 20, 2019

12 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@aanderse aanderse deleted the aanderse:tt-rss branch Jul 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.