Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

betterlockscreen: add missing runtime dependencies #64376

Merged

Conversation

@emmanuelrosa
Copy link
Contributor

commented Jul 6, 2019

Motivation for this change

The motivation for this change is to add missing runtime dependencies on:

  1. procps (pidof)
  2. xrdb

These dependencies may not be missing when using betterlockscreen from an environment such as the "system path", but they can be witnessed as missing from within a pure nix-shell, for example.

Example 1

[nix-shell:~]$ betterlockscreen -u /home/emmanuel/Media/Images/backgrounds/current.jpg
Got 1366x768 /home/emmanuel/.cache/i3lock/1366x768
/nix/store/kv7qjbzpn8nsa0rhyw1czy4wjdic88d1-betterlockscreen-3.0.1/bin/.betterlockscreen-wrapped: line 141: xrdb: command not found
/nix/store/kv7qjbzpn8nsa0rhyw1czy4wjdic88d1-betterlockscreen-3.0.1/bin/.betterlockscreen-wrapped: line 141: xrdb: command not found
/nix/store/kv7qjbzpn8nsa0rhyw1czy4wjdic88d1-betterlockscreen-3.0.1/bin/.betterlockscreen-wrapped: line 141: xrdb: command not found
/nix/store/kv7qjbzpn8nsa0rhyw1czy4wjdic88d1-betterlockscreen-3.0.1/bin/.betterlockscreen-wrapped: line 141: xrdb: command not found

Example 2

[nix-shell:~]$ betterlockscreen -l dimblur
Got 1366x768 /home/emmanuel/.cache/i3lock/1366x768
/nix/store/kv7qjbzpn8nsa0rhyw1czy4wjdic88d1-betterlockscreen-3.0.1/bin/.betterlockscreen-wrapped: line 70: pidof: command not found
/nix/store/kv7qjbzpn8nsa0rhyw1czy4wjdic88d1-betterlockscreen-3.0.1/bin/.betterlockscreen-wrapped: line 95: pidof: command not found
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after) - before: 148788144 after: 155766472
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut

This comment has been minimized.

Copy link
Member

commented Jul 6, 2019

@GrahamcOfBorg build betterlockscreen

@teto

teto approved these changes Jul 7, 2019

@worldofpeace worldofpeace force-pushed the emmanuelrosa:betterlockscreen-missing-dependencies branch from c176b04 to eb0332d Jul 11, 2019

@worldofpeace worldofpeace merged commit 63109c8 into NixOS:master Jul 11, 2019

@emmanuelrosa emmanuelrosa deleted the emmanuelrosa:betterlockscreen-missing-dependencies branch Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.