Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kbfs: 2.11.0 -> 4.1.0 #64377

Merged
merged 2 commits into from Jul 7, 2019

Conversation

@worldofpeace
Copy link
Member

commented Jul 6, 2019

The kbfs code has been moved to the same
repo as the keybase package.

Motivation for this change

Fixes #64248

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace referenced this pull request Jul 6, 2019
3 of 10 tasks complete
@das-g

das-g approved these changes Jul 6, 2019

@worldofpeace

This comment has been minimized.

Copy link
Member Author

commented Jul 6, 2019

I will merge this once I've manually tested this on master.

@worldofpeace worldofpeace requested a review from kalbasit Jul 6, 2019

@kalbasit
Copy link
Member

left a comment

No modules upstream? 😣


dontRenameImports = true;

src = keybase.src;

This comment has been minimized.

Copy link
@kalbasit

kalbasit Jul 6, 2019

Member
Suggested change
src = keybase.src;
inherit (keybase) src version;

And also remove version assignment above.

worldofpeace added some commits Jul 6, 2019

kbfs: 2.11.0 -> 4.1.0
The kbfs code has been moved to the same
repo as the keybase package.

@worldofpeace worldofpeace force-pushed the worldofpeace:kbfs branch from 6db9e81 to d8bbbeb Jul 6, 2019

@worldofpeace

This comment has been minimized.

Copy link
Member Author

commented Jul 6, 2019

Thanks @kalbasit.

No modules upstream? 😣

Yeah unfortunately not. Seems that reorganization and things like that aren't a small task.

@kalbasit kalbasit merged commit 16aa355 into NixOS:master Jul 7, 2019

16 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
kbfs on aarch64-linux Success
Details
kbfs on x86_64-darwin Success
Details
kbfs on x86_64-linux Success
Details

@worldofpeace worldofpeace deleted the worldofpeace:kbfs branch Jul 7, 2019

@jacobgreenleaf jacobgreenleaf referenced this pull request Jul 7, 2019
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.